Add 3.12 to tox #2116
Add 3.12 to tox #2116
Conversation
| @@ -79,6 +80,8 @@ jobs: | |||
| - python-version: py310 | |||
| package: "sklearn" | |||
| - python-version: py311 | |||
| # package: "sklearn" | |||
| # - python-version: py312 | |||
There was a problem hiding this comment.
Unsure about this "exclude section"
There was a problem hiding this comment.
This is fine to be excluded, tests fails too trying to bump to scikit-learn 1.0.x (that is still an old version)
| @@ -39,6 +40,8 @@ jobs: | |||
| exclude: | |||
| - python-version: py311 | |||
| package: "prometheus-remote-write" | |||
| # - python-version: py312 | |||
| # package: "prometheus-remote-write" | |||
There was a problem hiding this comment.
Unsure about this "exclude section"
There was a problem hiding this comment.
the test works fine here with python 3.12. Plenty of warnings but tox is happy
===================================================== 27 passed, 345 warnings in 0.07s =====================================================
py312-test-exporter-prometheus-remote-write: OK (17.43=setup[1.48]+cmd[3.12,2.86,3.18,2.97,3.47,0.35] seconds)
github-actions
bot
assigned codeboten, federicobond, NathanielRN, nikosokolik, ocelotl, oxeye-nikolay and shalevr
|
Boto failing. Maybe it's related to this. Maybe we need to update: boto/botocore#2979 |
| @@ -22,6 +22,7 @@ classifiers = [ | |||
| "Programming Language :: Python :: 3.9", | |||
| "Programming Language :: Python :: 3.10", | |||
| "Programming Language :: Python :: 3.11", | |||
| "Programming Language :: Python :: 3.12", | |||
There was a problem hiding this comment.
It does not work with that and there aren't newer releases
| pypy3-test-instrumentation-aio-pika-{0,1,2,3} | ||
| lint-instrumentation-aio-pika | ||
|
|
||
| ; opentelemetry-instrumentation-kafka-python | ||
| py3{8,9,10,11}-test-instrumentation-kafka-python | ||
| py3{8,9,10,11,12}-test-instrumentation-kafka-python |
| @@ -79,6 +80,8 @@ jobs: | |||
| - python-version: py310 | |||
| package: "sklearn" | |||
| - python-version: py311 | |||
| # package: "sklearn" | |||
| # - python-version: py312 | |||
| package: "sklearn" | |||
There was a problem hiding this comment.
Need to add
- python-version: py312
package: "kafka-python"
- python-version: py312
package: "boto"
| @@ -22,6 +22,7 @@ classifiers = [ | |||
| "Programming Language :: Python :: 3.9", | |||
| "Programming Language :: Python :: 3.10", | |||
| "Programming Language :: Python :: 3.11", | |||
| "Programming Language :: Python :: 3.12", | |||
There was a problem hiding this comment.
boto is abandonded and so won't work with 3.12
| pypy3-test-instrumentation-dbapi | ||
| lint-instrumentation-dbapi | ||
|
|
||
| ; opentelemetry-instrumentation-boto | ||
| py3{8,9,10,11}-test-instrumentation-boto | ||
| py3{8,9,10,11,12}-test-instrumentation-boto |
There was a problem hiding this comment.
boto is abandonded and won't support 3.12
Description
Add tox 3.12 support
Does This PR Require a Core Repo Change?
open-telemetry/opentelemetry-python#3616